Comment 14 for bug 1803787

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for the refactor, Bill.

I took a stab at adding the Shift+F10 functionality here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1803787-ang-grid-context-menu

The branch is called user/sandbergja/lp1803787-ang-grid-context-menu

The problem with my branch is that when you press Enter to select an Action from the context menu, it also triggers the onRowActivate event, which causes problems. So, in the majority of the admin interfaces, tabbing to "Edit Selected Rows" and pressing enter causes the edit modal to attempt to open twice, causing problems. Something fun to play around with, though!

Testing notes from my commit:
1) Open an eg2 grid interface (Server Administration -> Authority
Thesaurus is a good one).
2) Use the tab key to set focus onto the checkbox for one of the rows.
3) Note that pressing Shift + F10 opens the browser's context menu.
4) Apply this commit
5) Repeat steps 1+2
6) Press Shift + F10.
7) Note that the context menu opens, and that you can use Tab and
Shift+Tab to move through the various actions.
8) Note that you can press the Esc key to exit the context menu

I was also thinking that it would be nice for the sandbox to include an example of the action separators, but that doesn't seem essential to me.

If 3.2 backporting would be very difficult, I think that it is okay not to backport.