Comment 11 for bug 1803787

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for the i18n explanation, Bill. That sounds excellent.

I did some basic keyboard navigation testing on this, too. A few notes from that:

* The entries in the context menu are <a> tags without href attributes, which are not keyboard focusable. Could you please add a href attribute or change them into buttons, or do something else to make them focusable?
* Once menu items are focusable, as soon as the context menu opens, the first menu item should receive focus. (See the keyboard nav section under "Menu" in the WAI-Aria authoring practices: https://www.w3.org/TR/wai-aria-practices/#menu)
* On Linux in Firefox and Chrome, pressing Shift + F10 opens the browser's default context menu, rather than the eg-grid one. My laptop keyboard doesn't have a menu button, so I didn't have a chance to test with that. I also don't know what keyboard shortcuts a Mac user might expect. This seems less important, since keyboard users can still access the Actions menu, but it might be nice to allow a slick keyboard shortcut to open up the context menu too.