Comment 1 for bug 1801964

Revision history for this message
Jason Stephenson (jstephenson) wrote :

The entire process for handling EDI, both pushing and fetching, could benefit from more robust error handling. As it is, any errors with pushing are pretty much ignored and require manual intervention on the part of an administrator with access to the database and/or production servers. This could be avoided with some sensible code in the EDI processes.

Errors when fetching aren't so bad, since they will be retried the next time that the fetcher runs, but the fetcher should still not attempt to run commands if it fails to connect, or to login, to the remote server. Messages like "Can't call method "ls" on an undefined value at /usr/local/share/perl/5.22.1/OpenILS/Utils/RemoteAccount.pm line 648." should not show up in the log files as a routine thing.

It looks like the new edi_order_pusher.pl will suffer some of the same problems as the current pusher and fetcher because it uses the same infrastructure underneath for sending messages to the vendor: OpenILS::Utils::RemoteAccount. Presently, there's no way for connection errors to be caught by RemoteAccount's clients.