I can see arguments either way, and I prefer to leave the code unchanged. I hesitate to add yet another option to handle hold shelf expire times.
The main problem that we're trying to solve is to not return a patron's unfilled holds because they may then think that these unfilled holds are available. We haven't had any reported issues with expired holds in the 2+ months that we've been using the code.
I can see arguments either way, and I prefer to leave the code unchanged. I hesitate to add yet another option to handle hold shelf expire times.
The main problem that we're trying to solve is to not return a patron's unfilled holds because they may then think that these unfilled holds are available. We haven't had any reported issues with expired holds in the 2+ months that we've been using the code.