Comment 6 for bug 1791791

Linda Jansova (skolkova-s) wrote :

I have also noticed that line 63 in Open-ILS/src/templates/opac/parts/js.tt2):

<script src='[% ctx.media_prefix %]/js/ui/default/opac/ac_google_books.js' async defer></script>

does not include "type="text/javascript" like all the other occurrences of links to external javascript files do.

Could that cause any problem?

The link to the JavaScript file was added in 2017:

https://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/src/templates/opac/parts/js.tt2;h=f7fc737754b02c95c1274c72ae0c713719a91fa8;hp=1deac9143452b2aec703c9a03802480a3791996b;hb=55aa6265712b38eb746aa69c5ea93702d1b6950c;hpb=07466251f2c0d60a5c6aaebb23c87d5cf26c7f02

I am not entirely sure when exactly the preview started not to show up properly but - given the fact that we usually upgrade our installs in summer - it seems likely that the changes made in May 2017 may have given rise to the problem.