Comment 10 for bug 1791791

Revision history for this message
Garry Collum (gcollum) wrote :

A proposed patch is here. https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=bfe0d8f01b087867320692c3ba01138b3810c566

It has to do with how that ISBNs are rendered. With the ;query string in the URI the ISBNs are rendered like this.

<ul>
    <li class='rdetail_isbns'>
        <strong class='rdetail_label'>ISBN:</strong> 978-80-271-0378-2

Without the ;query string they are rendered like this:

<ul>
    <li class='rdetail_isbns'>
        <strong class='rdetail_label'>ISBN:</strong>
        <span class='rdetail_value' property='isbn'>978-80-271-0378-2</span>

The javascript that queries google is looking for the ISBN value the 'rdetail_value' class.

There are two variables in the code that render the ISBN value. One was wrapped in a <span> assigned the rdetail_value class and the other was not. The patch just fixes the one that was not assigned that class. I really don't know why adding ';query' to the URL favors one ISBN variable over the other.