I know Erica is looking at this fix, but I am trying to reproduce the bug in a master circa 3.7.1 system without the fix, and am not able to. Possibly, I could be missing something.
I cannot reproduce it when I follow the steps in the description to approximate it in Concerto. Here are my steps:
- Verify that action.circulation.id 7 has stop_fines and stop_fines_time set.
- Update action.circulation.id 7 to have stop_fines_time and stop_fines of NULL:
update action.circulation
set stop_fines = NULL,
stop_fines_time = NULL
where id = 7
- Run the fine generator
- Note that the total overdue fines due for the transaction has not changed
- Check stop_fines and stop_fines_time in the circ
select stop_fines_time, stop_fines
from action.circulation
where id = 7
This reveals that stop_fines = MAXFINES and stop_fines_time is the time the fine generator was run.
I will attempt to modify the due date in a circulation as described in the first procedure and rerun the fine generator when the new due date has passed.
I did note that when I choose a circulation in the client that has acheived MAXFINES and choose Edit Due Date under Actions, the circulation retains the MAXFINES stop_fines and stop_fines_time.
I know Erica is looking at this fix, but I am trying to reproduce the bug in a master circa 3.7.1 system without the fix, and am not able to. Possibly, I could be missing something.
I cannot reproduce it when I follow the steps in the description to approximate it in Concerto. Here are my steps:
- Verify that action. circulation. id 7 has stop_fines and stop_fines_time set.
- Update action. circulation. id 7 to have stop_fines_time and stop_fines of NULL:
update action.circulation
set stop_fines = NULL,
stop_fines_time = NULL
where id = 7
- Run the fine generator
- Note that the total overdue fines due for the transaction has not changed
- Check stop_fines and stop_fines_time in the circ
select stop_fines_time, stop_fines
from action.circulation
where id = 7
This reveals that stop_fines = MAXFINES and stop_fines_time is the time the fine generator was run.
I will attempt to modify the due date in a circulation as described in the first procedure and rerun the fine generator when the new due date has passed.
I did note that when I choose a circulation in the client that has acheived MAXFINES and choose Edit Due Date under Actions, the circulation retains the MAXFINES stop_fines and stop_fines_time.