Evergreen

Bug #1779158
Comment #14

Comment 14 for bug 1779158

Revision history for this message

Jane Sandberg (sandbergja) wrote on 2018-12-02:

#14

It's looking good so far, Bill. A few things I noticed:

* In the dojo version of the import tab, the Remove MARC Field Groups selector disappears when the user selects authority records from the dropdown. In the angular version, it does not. I'm not sure if that functionality just doesn't exist yet, but it seems like it should disappear or be greyed out to maintain parity. In addition, it also seems like "Auto-overlay In-process Acquisitions Copies" should disappear/be inactive for authority records, since it's not relevant to authority records.

* I wasn't able to upload an authority record at all. I got an error message in the console: "ERROR open-ils.vandelay.authority.process_spool failed! stat=404 msg=Method [open-ils.vandelay.authority.process_spool] not found for OpenILS::Application::Vandelay"

* There is some indication of which fields on the import tab are required (a great improvement over dojo! Thanks!), but it relies on color. This is a problem for blind and colorblind users: https://www.w3.org/TR/2016/NOTE-WCAG20-TECHS-20161007/F81

* The <input>s in the import tab are not associated with their labels. They should be associated for better accessibility and usability.

* In general, the import tab has a cluttered feel. It might be easier for users if there were some more separation + whitespace used to group like settings.

* There is a misspelling: "Select or Create a Qeueue" -- "Qeueue" should be "Queue"

* A usability issue: the upload button should light up after I type in a name for the queue and select a file to upload. However, if I start by choosing a file to upload, then type a name for the queue, the upload button does not light up until after I remove focus from the queue name field, by clicking out of it or tabbing to another field.

Additionally, I'm not totally sure when I'd use the recent imports tab and when I'd use the inspect queue tab. Could you please tell me a bit more about why those would be two separate tabs?

Thanks very much for your work on this! It was fun to try it out. Since you mentioned that you want a lot of testing for this, I also gave this the needsdiscussion tag, so hopefully more end users can take a look.

It's looking good so far, Bill.  A few things I noticed:

* In the dojo version of the import tab, the Remove MARC Field Groups selector disappears when the user selects authority records from the dropdown.  In the angular version, it does not.  I'm not sure if that functionality just doesn't exist yet, but it seems like it should disappear or be greyed out to maintain parity.  In addition, it also seems like "Auto-overlay In-process Acquisitions Copies" should disappear/be inactive for authority records, since it's not relevant to authority records.

* I wasn't able to upload an authority record at all.  I got an error message in the console: "ERROR open-ils.vandelay.authority.process_spool failed! stat=404 msg=Method [open-ils.vandelay.authority.process_spool] not found for OpenILS::Application::Vandelay"

* There is some indication of which fields on the import tab are required (a great improvement over dojo!  Thanks!), but it relies on color.  This is a problem for blind and colorblind users: https://www.w3.org/TR/2016/NOTE-WCAG20-TECHS-20161007/F81

* The <input>s in the import tab are not associated with their labels.  They should be associated for better accessibility and usability.

* In general, the import tab has a cluttered feel.  It might be easier for users if there were some more separation + whitespace used to group like settings.

* There is a misspelling: "Select or Create a Qeueue" -- "Qeueue" should be "Queue"

* A usability issue: the upload button should light up after I type in a name for the queue and select a file to upload.  However, if I start by choosing a file to upload, then type a name for the queue, the upload button does not light up until after I remove focus from the queue name field, by clicking out of it or tabbing to another field.

Additionally, I'm not totally sure when I'd use the recent imports tab and when I'd use the inspect queue tab.  Could you please tell me a bit more about why those would be two separate tabs?

Thanks very much for your work on this!  It was fun to try it out.  Since you mentioned that you want a lot of testing for this, I also gave this the needsdiscussion tag, so hopefully more end users can take a look.