Web Client: Copy Buckets Request Selected Copies Doesn't Work

[Jennifer Pringle]

Evergreen 3.1

In the copy bucket interface there is an option to "Request Selected Copies". If you select this option the pop up appears as expected and is the same as in the client. You can select Copy Hold, Recall Hold, or Force Hold. No matter which one you select when you click OK the pop up disappears but no holds are placed.

In the 2.12 XUL client I can place holds when selecting Copy Hold or Force Hold. Recall Hold fails with a permissions failure which is not unexpected on our test server as we don't currently have recalls set up. In each case the xul client gives acknowledgement of the success or failure of the holds.

[Garry Collum (gcollum)]

When trying to place a Copy Hold I am receiving an error of "ERROR: null value in column "target" violates not-null constraint" in the opensrf log. For the other two types of holds I am receiving messages of 'retrieve asset.copy called with no ID...' and 'rolling back db session.'

[a. bellenir (abellenir)]

i think this was just missing a return statement in the function given to map.

here's a branch with the 'return' added: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1778810-copy-buckets-request-selected

> the xul client gives acknowledgement of the success or failure of the holds.

i did not attempt to implement this part.

[Jennifer Pringle (jpringle-u)]

I tested this on a 3.1.5 sandbox and I'm still not seeing any holds placed.

[Christopher Burton (cburton)]

I can confirm that the above fix has worked on my test server running 3.1.8

[Christopher Burton (cburton)]

Also worked in production with 3.1.5.

I would note that this would require rebuilding the angular library, although it seems the change doesn't make it to the file.

What I did to fix this was:
Download the EG tarball for the version I was using
Make the change in the extracted files
Rebuild the angular libraries with npm
Copy the build to the openils site
--The edit didn't make it's way to the app.js file in /openils so I had to make the edit there as well
Then restart OpenSRF and Apcache

And it works! ...For me at least.

***I would also note that tagging these items for a hold does not give any confirmation that it works or didn't.

[Terran McCanna (tmccanna)]

This appears to be a duplicate of: https://bugs.launchpad.net/evergreen/+bug/1806394