Comment 34 for bug 1777677

Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed a rebase to

user/gmcharlt/lp1777677_test_notification /
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1777677_test_notification

The branch also contains a follow-up tweaking the test notification buttons on the patron registration form:

    * moves the 'Send Test Email' button in the patron registration form
      to cuddle next to the 'Invalidate' button
    * disables the 'Send Test Email' button if the email address is
      changed on the form
    * disables the 'Send Test Text' button if the SMS carrier or
      SMS text number is changed on the form

    The point of the last two changes is to prevent staff members
    from sending a test message prior to saving changes to the email
    address or SMS number, as otherwise the test methods would not
    have access to the new values.

I would appreciate review of that follow-up, but once that's done, I am otherwise prepared to merge this.