Comment 13 for bug 1777677

Thanks Kyle! I like the feature! I found a few issues in testing.

1. When in the patron editor, the test button immediately appears after adding an email address or SMS number for the patron. However, if the record has not yet been saved with those changes, the notification will be sent with nothing in the "To" line. Could that "Test" button only appear after the email address or SMS number has been saved to the user's record?

2. When testing the notification method in the public catalog, I was only get it to get it to work when the logged-in user was a staff user. When I was logged in with a public user Concerto account, which has fewer permissions, the action trigger event is never created. Is there a permission to this feature that would prevent it from working for public users?

3. In the public catalog, the test notification action for the SMS number is using the email test event, not the SMS test event.

4. When clicking the action to send an email or SMS test message, the screen shifts in a way that makes it difficult to see the resulting confirmation message. See https://drive.google.com/file/d/1vuNg6TX37vhNtHl8dUVYoWVvOH-fb5ri/view I think users may click the link multiple times before they realize the message was sent. I'm not sure of the best way to handle this. Maybe the confirmation could appear to the right of the email address instead of below it? Or even above the email address would make it more visible. Using red font for the confirmation message may also help.

5. I just have some suggested language changes. For the SMS message, I wouldn't use the term 'SMS' since most users don't know what this means. Maybe we could change it to say "Test text message / This is a test confirming your mobile number for [library name] is correct." For the confirmation message in the public catalog, I would prefer to see "Message Sent" instead of "Notification Sent." "If you do not receive and email message" or "If you do not receive a text message."

I could make the changes in #5 when signing off on the branch, but I'm putting the suggestions here in case the other issues aren't fixed until after I leave.

Thanks again!