Comment 21 for bug 1777207

Revision history for this message
Dan Wells (dbw2) wrote :

I've looked over the code, and it looks good. Just a few questions/comments.

First, I think the sort reset added in the last commit is a good idea and should simply be the default, non-optional behavior, similar to resetting the offset to 0. Like the offset reset, the whole concept of "prepending" depends upon the sort not affecting new results. Otherwise, we are doing some sort of "insert" behavior which I think is always going to be a bad UX for a grid, i.e. a visual hunt for the new row on every action.

Second, I don't quite understand yet why we must do the collect() in the post-sort/sort-reset prepend case. I imagine it is needed and plan to poke some more to understand why, but if someone more familiar can guess what detail I might be missing and help me understand, I would be most appreciative.

Our staff will be very happy with this fix. Thanks, Galen!