Comment 6 for bug 1776757

Revision history for this message
Galen Charlton (gmc) wrote :

Upon reviewing the patch, I note that changing the type of the input (per comment #4) removes a bit of form validation: specifically, non-numeric values for the amount would be permitted to be submitted. Of course, the billing will fail to be saved, but it is a bit of extra untidiness.

I think more form validation would be better than forcing the display of two decimal places, so I've taken the liberty of pushing this with a follow-up that keeps the input as a number. This is now in master, rel_3_5, and rel_3_4. Thanks, Mike and Terran.

It would be possible to have our cake and ensure that the input displays two decimal places when a default price is applied, but that would require either a customer validator or use of ng-currency. I'll leave it to somebody else to file a bug if they choose to work on it.