Comment 6 for bug 1774268

I tested on 3.1.7.

I can confirm the above issues:

1. deselecting all checkboxes from Patron Edit and My Account adds different values in the usr_setting entry: ":" from Patron > Edit; "" from My Account

2. entry with "" in usr_setting is not correctly reflected as none checkbox being selected on Patron > Edit

If ":" is preferred for not_to_notify choice, the old value of "" needs to be taken care of.

Additional related findings:

If opac_hold_notify usr_setting_type has no default value, no entry is created for newly created patrons, though both email and phone checkboxes appear selected on Patron Registration/Edit/Place Hold/My Account.

If "phone:email" is set as the registration default in the usr_setting_type, you will see the same behaviour, but there is an entry with value of ":phone:email" created on patron registration.

This is XUL behaviour, too. We use the default value to force creating the usr_setting entry.

Tina Ji
BC Libraries Coop