Comment 5 for bug 1774268

I have tested this patch on a 3.2 system, and I'm seeing a couple issues with it.

* specify a default hold notify of ':phone:email' (maybe someday make this a configurable setting)
In my testing, registering a patron without changing notify preferences did not create a user setting for the patron. This was how the XUL client behaved. LP bug #1361258 sought to fix this by creating a default setting of "phone:email" for a patron created in the web client.

Adding the default setting was an improvement in a couple different fronts, including the OPAC, (see Full Testing below). There is also a community mobile app or two out there that only recognizes preferences if they exist in user settings.

Changes made in the OPAC to preferences are also not correctly reflected. If preferences are removed here, the setting is updated to an empty string, which the web client Edit screen now sees as phone/email notify but the Place Hold screen sees as "Do not notify".

Here are my thoughts after testing:
The current web client behavior works well for accounts created in the web client. The only issue comes from accounts created in the XUL client, but as the XUL client is deprecated in 3.2, perhaps a temporary solution of running a script to add user settings for opac.hold_notify of "phone:email" where they do not exist would be better.

Or, perhaps there would be a way to simply allow the web client Edit screen to translate a user with no hold notify settings as checkmarks for phone/email.

Here's my full testing:

Creating patron account in web client with default settings left:
- no user setting is added in database
- phone, email checked by default when placing a hold in web/xul/opac

Creating patron account in xul client with default settings left:
- no user setting is added in database
- phone, email checked by default when placing a hold in web/xul/opac

Updating default notify patron record in OPAC to remove all notify preferences:
- preferences screen shows email/phone not checked even though still set to default. Simply saving the screen does NOT update settings. Settings must be checked, saved, unchecked, and saved again to update...
- user setting updated to ""
- phone, email not checked by default when placing a hold in web/xul/opac

Updating patron record in web client to remove all notify preferences:
- user setting updated to ":"
- phone, email not checked by default when placing a hold in web/xul/opac

Updating patron record in xul client to remove all notify preferences:
- user setting updated to ":"
- phone, email not checked by default when placing a hold in web/xul/opac

EXTRA PROBLEM:
- when a patron record with an empty string, "", is opened in the web client, phone/email show checked by default on Edit screen even though this is reflected as a "don't notify" on the Place Hold screen
- saving the edit screen without making any changes keeps the empty string setting.