Comment 4 for bug 1773417

Revision history for this message
Dan Wells (dbw2) wrote :

Jason, thank you for testing this branch. I am sorry it did not work as expected for you.

The checkbox commit is unchanged from Mike's original fix and in my testing the behavior is identical. I would describe said behavior as "quirky but functional" :) Being quirky, it is a little hard to describe, but basically, it boils down to a few things:
1) If both boxes are checked, unchecking "Show volume detail" will uncheck "Show copy detail".
2) If "Show volume detail" did this unchecking, it will re-check "Show copy detail" if the user re-checks "Show volume detail"
3) [this is the quirky bit] Checking "Show copy detail" without "Show volume detail" checked never adds to the detail level, but it does change the underlying state of the box. If "Show copy detail" is unchecked, then you uncheck "Show volume detail", the box is now (in essence) "double-unchecked". An attempt the check the box will leave it unchecked, but will cause it to be checked if one now checks "Show volume detail". A second attempt to check the box will succeed in checking it, but again, the actual detail level is not affected, as there is no ability to "Show copy detail" without also showing volume detail.

My reading of the testing on the original bug was that this behavior was noted and deemed an acceptable level of improvement, as major errors were avoided, and desired display states were not hard to achieve despite interface imperfections.

My changes attempt only to address regressions, so some rough edges remain (a feature not exclusive to this branch!). If it helps for comparing behaviors, Mike's branch is still running here (as of 5/25):
https://dev-bugsquash.equinoxinitiative.org/eg/staff/

Finally, this comment is a little longish already, so I will address your other concern separately...