Copy alert types are untranslated

[Eva Cerninakova]

Copy alert types are not translated, see the attachment.
According to my finding, the string for copy alert types (like Checkin of lost copy, Checkin of missing copy, Checkin of lost-and-paid copy etc.) are completely missing in translation files in Launchpad.

[Linda Jansova (skolkova-s)]

It is still valid in Evergreen 3.3.2, making the copy alerts very difficult to use for staff members who are not good enough at English.

[Eva Cerninakova (ece)]

It is still valid in Evergreen 3.6.2

[Eva Cerninakova (ece)]

The problem remains unsolved in the Angular web staff client in the bug squashing test server (bugsquash2.mobiusconsortium.org), see the attachment.

[Bill Erickson (berick)]

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1770979-copy-alert-type-xlate

From the commit:

Admin -> Local Admin -> Copy Alert Types is now an Angular page.

Copy Alert Type 'Name' field is now translatable

Fixes a formatting issue in Angular fm-editor so that the translate button appears on the same line as the value it means to translate.

Includes grid prefs SQL

[Eva Cerninakova (ece)]

Thanks Bill, that's great.

[Eva Cerninakova (ece)]

I have tested the bug using https://festivus.evergreencatalog.com/eg/staff/ server.

The copy alert type name seems to me definitely translatable, although, I wasn't able to test the translation fully because there is only English language available to translate to, which means, that adding English translation just changes the Copy Alert Type Name.

[Jane Sandberg (sandbergja)]

Thanks, Bill. I noticed a few regressions on the item alert type form:

* The order of the fields is different in the angular version from the angjs version. The fieldOrder should be: 'name,active,state,event,scope_org,next_status,in_renew,invert_location'
* The state field should be a dropdown with a list of status names
* The event field should be a dropdown with three options: Any Event / Checkin / Checkout
* The next status field should be a multi-select with a list of status names. It should be readonly unless the event field is set to Checkin.

[Galen Charlton (gmc)]

I've pushed an alternative patch to the branch user/gmcharlt/lp1770979_ccat_name_i18n

This focuses just on making the ccat.name field accessible to batch translation. As Jane noted, there's enough stuff going on in the AngularJS admin interface for ccat that it needs more than just the autogenerated Angular admin interface.

[Galen Charlton (gmc)]

I've also opened bug 2013792 regarding the Angularization of the Item Alert Types admin interface.

[Blake GH (bmagic)]

There are number of merge conflicts on main today. I took a stab at rebasing:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/blake/lp1770979-copy-alert-type-xlate

I'll put this branch on our test server for bugsquashing week

[Eva Cerninakova (ece)]

I tested copy alerts using both Czech and English localization on Blake's server, https://bugsquash.mobiusconsortium.org/.

In the Item Alert management tool (in Item Attributes editor) and in the Item Alert Type administration screen, Item alert types were displayed in English. However, it was obvious, that item alert types strings had been marked for translations
in open-ILS/src/eg2/src/app/staff/share/holdings/copy-alert-manager.component.html, so I assumed that the alerts were displayed in English because the translations were not created yet.

The Apply Translation button in Item Alert Type administration screen works as expected, all terms can be translated without problems, translations can also be modified if needed.

All translations were immediately applied both to the list of alert types in the Item Alert Type administration screen and to the alert menu in the Item Alert editor or the Item Alert management tool. Alerts were always correctly displayed according to the selected localization.

I also didn't encounter any problem when creating item alert or during the checking and checkout process.

I confirm that everything works as expected.

I have tested this code and consent to signing off on it with my name, Eva Cerniňákováand my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Note for committer: Signed off, but needs rebase before committing

[Terran McCanna (tmccanna)]

Note: I believe the patch that was tested and signed off was Bill's patch, rebased by Blake. However, I wanted to note that Galen submitted an alternate patch in comment #9.