Remove org unit settings that are no longer valid in web client

[Kathy Lussier]

There are a number of settings in the Library Settings Editor specific to the xul client that will no longer be valid once the xul client is completely removed. We should remove those settings so that people don't get frustrated when they try getting them to work in the web client. A starter list of settings is below:

* Button Bar
* GUI: Hide these fields within the item attribute editor (this is currently done with settings saved in the browser)
* Horizontal layout for Volume/Copy Creator/Editor.
* Patron circulation summary is horizontal
* Unified Volume/Item Creator/Editor

I'm not sure about this one:
* Cap results in patron search at this number

With paging, I was thinking we wouldn't need to cap results anymore, but it does take a long time to retrieve results for an overly broad search, so maybe we need to consider reimplementing it again.

There are probably other library settings that don't work in the web client, but I tried to restrict this list to ones that are no longer needed in the web client. We agreed as a community not to offer horizontal/vertical options for the patron and copy editors. We also now offer the cataloging unified interface for everyone.

Feel free to add settings to this list that I may have missed.

[Bill Erickson (berick)]

I can confirm we're not using the "Cap results in patron search at this number" setting in the client. Also, we have implicit search limits in place now that correspond to the grid row counts, e.g. limit 25 results per grid page. I think we can safely remove this setting.

[Kathy Lussier (klussier)]

Adding a note that, as mentioned in bug 1771652, as part of this bug, we could also update descriptions for other bugs so that they make more sense in the web client world. One of those settings is Items Out Claims Returned, Lost and Long-Overdue Display settings, which refer to displaying specific checkouts in the top or bottom pane of the Items Out page. These options are now presented in separate tabs of the Items out page.

[Remington Steed (rjs7)]

I posted a branch on bug 1325704 that addresses the YAOUS descriptions that Kathy mentioned in comment #2.

[Remington Steed (rjs7)]

Here is a list of settings that don't appear in any non-XUL code in master (to the best of my understanding). This includes those mentioned in the original bug report. Are any of these being used in a secret location, or possibly will be supported in the web client soon?

acq.fund.balance_limit.block
acq.fund.balance_limit.warn
acq.holds.allow_holds_from_purchase_request
circ.auto_hide_patron_summary
circ.hold_expire_alert_interval (see bug 1688356)
circ.hold_stalling_hard
circ.holds.target_holds_by_org_unit_weight
circ.staff_client.actor_on_checkout
format.time
gui.disable_local_save_columns
notice.telephony.callfile_lines
print.custom_js_file
ui.cat.volume_copy_editor.horizontal
ui.circ.patron_summary.horizontal
ui.general.button_bar
ui.general.hotkeyset
ui.hide_copy_editor_fields
ui.patron.edit.aua.county.show
ui.patron_search.result_cap
ui.unified_volume_copy_editor
url.remote_column_settings

And the following settings are only referenced in a perl live test (to my knowledge):

cat.spine.line.height
cat.spine.line.margin
cat.spine.line.width

[Kathy Lussier (klussier)]

Since acq is still using Dojo, I suspect those first two acq settings are still in use. If not, they should be in use as the fund balance limits are important to acq users.