Mark Item Damaged from Holding View Fails

[Robert J Jackson]

web client 3.0.5

When attempting to use Mark Item as Damaged from pull down for a selected item an error is encountered within Angular code. Attaching screen shot showing error.

[Elaine Hardy (ehardy)]

Confirmed in 3.0.2

[Christine Burns (christine-burns)]

Confirmed in 3.1

Mark Item Damaged from Check In Screen also fails

Check in Item CONC90000437 -> Actions Mark item damaged -> popup 1 (notice item details are missing) -> nothing happens, popup 2 does not appear

[a. bellenir (abellenir)]

i got the same error as the original report when marking an item as damaged on both the record's holdings view and from a patron's holds tab:
Error: [$injector:unpr] Unknown provider: egItemProvider <- egItem

it's missing the definition of egItem (../circ/services/item.js)

here's a branch that includes the missing javascript file in the index.tt2 templates:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1759864-mark-item-damaged-from-holdings-view-fails

i didn't get errors from the checkin screen, however, so that might be a separate bug.

[Jason Stephenson (jstephenson)]

I'm curious what happens if you try after applying the branch from bug 1779467 without your branch applied.

[a. bellenir (abellenir)]

Jason: if i do that, javascript console says:
Error: [$injector:unpr] Unknown provider: egItemProvider <- egItem

same as before.

[Remington Steed (rjs7)]

I think Christine's check-in comment (#3) may be partly caused by bug #1756441 (marking damaged fails silently on in-transit items). In any case, I agree with abellenir that it seems like a different bug from this one.

When I tested the branch in #4, it removed the errors and fixed the behavior from the Patron Hold tab, but the Holdings View still has a minor problem. Here's what I'm seeing:

- Right-click an "Available" item, choose "Mark: Item as Damaged"
- Confirmation popup looks right, click "Submit"
- Grid refreshes, but item still shows "Available"
- After another refresh, however, it shows the item as "Damaged", so the changed worked, but the timing seems to be wrong.

It seems likely that this is a separate bug that was hidden by the first one, and overall the situation is much improved. So I'll post a signoff branch.

[Remington Steed (rjs7)]

Signed off here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1759864-mark-item-damaged-from-holdings-view-fails

[Bill Erickson (berick)]

Thanks, all. Issue and fix confirmed. Merged to 3.2 and above.