Web client: Mark Item Damaged function fails silently on in transit items

[Michele Morgan]

When an attempt is made to mark an In transit item Damaged in the web client, the action fails with no feedback.

When the same attempt is made in the xul client, that Mark Damaged action succeeds, but a row remains for the transit in the action.transit_copy table even though the status of the item has been changed to Damaged.

Below are log entries for the failure in the web client:

[2018-03-16 15:58:45] open-ils.circ [INFO:32856:Circulate.pm:575:] circulator: pushing event ROUTE_ITEM
[2018-03-16 15:58:45] open-ils.circ [INFO:32856:Circulate.pm:561:] circulator: BAILING OUT
[2018-03-16 15:58:45] open-ils.circ [INFO:32856:Circulate.pm:287:] circulator: bailing out with events: ROUTE_ITEM
[2018-03-16 15:58:45] open-ils.circ [INFO:32856:CStoreEditor.pm:139:] editor[1|1] rolling back db session
[2018-03-16 15:58:45] open-ils.circ [INFO:32856:CStoreEditor.pm:139:] editor[1|1] request en-US open-ils.cstore.transaction.rollback []
open-ils.cstore 2018-03-16 15:58:45 [INFO:59333:osrf_app_session.c:1177:] [open-ils.cstore] sent 403 bytes of data to <email address hidden>/open-ils.circ_drone_at_localhost_32856
open-ils.cstore 2018-03-16 15:58:45 [INFO:59333:osrf_stack.c:163:] Message processing duration 0.000469
open-ils.cstore 2018-03-16 15:58:45 [INFO:59333:osrf_stack.c:163:] Message processing duration 0.000000
[2018-03-16 15:58:45] open-ils.circ [INFO:32856:Transport.pm:163:] Message processing duration: 0.333
[2018-03-16 15:58:45] open-ils.circ [INFO:59188:Circ.pm:1364:] try_checkin() received event: ROUTE_ITEM
[2018-03-16 15:58:45] open-ils.circ [WARN:59188:Circ.pm:1370:] try_checkin() un-successful checkin

[John Amundson (jamundson)]

Confirmed in 3.0.12ish.

I'll also note, since it is in a very similar vein, that in the XUL client, trying to mark an item In Transit as Missing fails with a pop-up stating it can be done.

However, in the web client, an item In Transit can be marked Missing, and its corresponding action.transit_Copy row is not cancelled.

[Jason Stephenson (jstephenson)]

I want to add that I am working on changes to the behavior of the Mark Item functionality that will likely address this bug. It looks like these changes will be ready for Evergreen 3.3. See https://bugs.launchpad.net/evergreen/+bug/1779467

I don't know if we want to mark this bug as a duplicate or not. Someone may come up with an alternate fix in the meantime.

[Remington Steed (rjs7)]

Confirmed in the 3.3.2 web client. I'm seeing the same errors in osrfsys.log after checking in an item that triggers a transit, and then trying to mark it damaged. No error is given to the user.

[Michele Morgan (mmorgan)]

Removed reference to xul client in description.

[Michele Morgan (mmorgan)]

Noting that this is still an issue in Evergreen 3.8.

[Michele Morgan (mmorgan)]

Also adding a link to related bug 1257910

[Dan Guarracino (dguarracino)]

Noting that this is still an issue in Evergreen 3.11.