Comment 1 for bug 1752434

Revision history for this message
Mike Rylander (mrylander) wrote :

I was confused for a while ... the difference is that we're depending on the titleNonfiling XSLT template in the mods32 stylesheet (in stock) to pull out the title string when using the Display Field highlighting, which restricts the subfields to a, b, f, g, and k, while the previous mechanism used a rather big hammer of get_graphic_880s() defined in misc_util.tt2. There are other titles extracted elsewhere, but that one in particular is, indeed, "all of 245, minus e, w, 0, 4, 5, 6, 7, 8, and 9". While I could certainly see adding n and p to the titleNonfiling XSLT definition, we don't want to go back to showing subfield "h", for instance.

I mentioned this in IRC, but IMO, the way forward is to always use the Display Field data when we have it, but only use the highlighted version when highlighting is turned on. The logic to do that would actually be a simplification of what's in there now, with just an adjustment to the DF mapping code in misc_util.js to choose between the appropriate versions, and removal of any other "are we highlighting" tests in the rest of the templates.

I will work on that soon, so I'll just assign myself now.