Web Staff Client: Pending Patrons limited to 100

[Terran McCanna]

In 3.0.2 Web Client:

The Pending Patrons grid is cutting off after the first 100 pending patron applications. Attempting to page to the next 100 simply reloads the same entries. Downloading full CSV downloads the same first 100. (The xul client in this particular case shows that there are 105 pending patrons.) New pending patrons that are added appear in the xul client, but not in the web client.

Since the web client is also missing the Delete button in that interface (bug https://bugs.launchpad.net/evergreen/+bug/1737800), staff cannot even opt to delete the oldest of the pending patrons to see the newer ones. They're only workaround to retrieve the newer pending applications is to install the xul client and access them through there, or to delete the older of the pending applications from there in order to get below the 100 limit.

The xul client defaulted to a limit of 100 (which could then be changed in the interface and refreshed), so perhaps the retrieval script in the web client was built with that artificial limit of 100 as well?

[Garry Collum (gcollum)]

The table only displays 100, but it also ignores the row limits along with pagination. If you have 30 pending patrons and limit the rows to 10, it still displays 30 rows.

[Jeff Godin (jgodin)]

This seems to be fixed by passing a count and offset to the backend API call.

Branch forthcoming.

[Jeff Godin (jgodin)]

Working branch for review: user/jeff/lp1749970_fix_pending_patron_paging

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/lp1749970_fix_pending_patron_paging

Note that while this begins to supply count and offset as arguments to the open-ils.actor.user.stage.retrieve.by_org call, we may end up making further changes (i.e., fetching all pending patrons) as part of fixing the client-side sorting in this interface -- see bug 1786501.

[Terran McCanna (tmccanna)]

Thanks, Jeff! I've confirmed that this fixes the paging bug. (The sort is still broken, but I'll go ahead and sign off on this one since the sort has a different bug.)

My sign-off patch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1749970_fix_pending_patron_paging_signoff

[Galen Charlton (gmc)]

Pushed to rel_3_4, rel_3_3, rel_3_2, and rel_3_1. Thanks, Jeff and Terran!