Web Client: Pending Patrons No Delete

Bug #1737800 reported by Scott Thomas on 2017-12-12
74
This bug affects 16 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.2
Undecided
Unassigned

Bug Description

In the Web Client at 3.0, the Pending Patron feature does not contain a Delete option. Only Load is present. Our libraries delete pending patrons whom they opt not to load due to various issues with the information provided by the patron.

Revision history for this message
Andrea Neiman (aneiman) wrote :

Confirmed on 3.0.1

tags: removed: web
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 3.next
Revision history for this message
Katie Greenleaf Martin (katiegmartin) wrote :

Just wanted to confirm that this is affecting us in 3.0.7. We can go into XUL and remove pending patrons but there does not seem to be a way to do it in webby.

Revision history for this message
Blake GH (bmagic) wrote :

+1 3.0.9

Revision history for this message
Meg Stroup (mstroup) wrote :

Confirming that this affects us in 3.1.5. We were able to delete in XUL, but that function is missing in the web client.

Jeff Godin (jgodin) on 2018-11-26
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
Jeff Godin (jgodin) on 2018-12-11
Changed in evergreen:
assignee: Jeff Godin (jgodin) → nobody
Cesar V (cesardv) on 2018-12-11
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
Revision history for this message
Cesar V (cesardv) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Tested in 3.2.2 and it worked great for me! Thank you, Cesar!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Bill Erickson (berick) wrote :

Cesar, could you please post another commit with the following changes:

1. Add your sign-off

2. Change
    $q.all(promises).then(refresh_page());
to
    $q.all(promises).then(refresh_page);

This way the refresh_page function is not called until after the promises are complete. Alternatively, wrap it up like .then(function() { refresh_page() });

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: 3.next → 3.2.3
Bill Erickson (berick) on 2019-01-10
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Cesar V (cesardv) on 2019-01-15
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
Revision history for this message
Cesar V (cesardv) wrote :
Revision history for this message
Bill Erickson (berick) wrote :

Thanks Cesar. Thanks Terran.

Re-tested new branch and merged to master / 3.2.

Changed in evergreen:
assignee: Cesar V (cesardv) → Bill Erickson (berick)
assignee: Bill Erickson (berick) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
status: Fix Committed → Fix Released
Changed in evergreen:
status: Fix Released → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers