Comment 20 for bug 1749502

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I saw the same issue that Jason mentioned in comment #19.

Wrapping the hold.js section in the "if(hold.current_copy() .*" block above that section seems to fix the problem with holds with no targeted copies being ignored. There was a console error about "hold.current_copy() being null.

I think I have this all working. Sorts by location order if set, then by location name(for the case when location order isn't used), then by Call Number prefix sortkey, then call number sortkey, then call number suffix sortkey.

I made one change in the interest of saving space, combining the prefix, call number and suffix in one column.

I also don't love the default order of the columns. I think it makes more sense to follow the sort order, I'm not sure why the hold type is the first item. But I don't actually use the list to pull items so maybe the Type, Title, Author... order is more effective?

working branch at
user/stompro/lp1749502-hold-pull-list-printing
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1749502-hold-pull-list-printing

Working branch at