Comment 4 for bug 1745427

Thanks for your work on this Galen.

I have been testing the patch on a 3.0 system. While the patch alleviates most of my concerns on this bug, (and even some from bug #1745425), there are a few things that are still a little funky.

Here are my observations.

1. If a subscription has multiple patterns, and Predict New Issues is chosen from a pattern on the "Manage Predictions" tab, it doesn't matter which pattern the button is attached to, the Predict New Issues screen defaults to the active pattern. If multiple patterns are active, then the pattern with the most recent ID is chosen. Since only one pattern should be active at once, I don't see this as a problem, just a little odd from a user standpoint.

2. After a prediction change, the Predict New Issues window will reflect the new pattern and will accept new enumeration/chronology captions, BUT if the publication date is adjusted, the prediction fails silently. (the failure produces the attached console error). This means the user will have to either adjust the holdings code of the most recent issue to produce the correct publication date or predict more and then delete until the correct set of issues/dates is present.

3. When Edit issue holdings codes is chosen on an issue using an old pattern, the Predict New Issues screen does not reflect the new pattern, (this can still be changed by moving the type from supplement back to basic). These leads the user into thinking the issue will maintain the old pattern with new values. However, if the type isn't changed and the code edited, the resulting issue is a weird amalgamation of the two patterns.

I know Mike has already pushed the fix, and I can come to terms with that because my observations will probably be edge cases, but I still wanted to mention them. I'll also note that bug #1745425 should still be left open because that problem is not fixed if a pattern change is not involved.