Comment 11 for bug 1744341

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I'm wondering if this will cause issues with frozen holds that have an expire_time set? I don't think the expire date mattered before this change for frozen holds, since they never made it to the "return unless $self->handle_expired_hold;" line.

Maybe frozen holds shouldn't have expire_time set? I'm seeing 19 frozen holds with it set and 3097 without it set in our production data. That makes me think that maybe some less used method to freeze holds isn't clearing the expire date. Like maybe the staff interface method of freezing a hold. That is probably a separate bug to deal with.

I'll continue testing.