Web Client: The Mark Damaged Popup has untranslateable strings

Bug #1742523 reported by Terran McCanna on 2018-01-10
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
3.1
Low
Unassigned
3.2
Low
Unassigned
3.3
Low
Unassigned

Bug Description

In 3.0.2: The "Charge Fees" and "No Charge" button strings in the "Mark Damaged" popup window are not coded as translatable strings.

Jane Sandberg (sandbej) on 2018-01-16
tags: added: i18n
Jane Sandberg (sandbej) wrote :

I created a branch for this here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1742523_making_mark_damaged_strings_translatable

But I have not tested it at all, and in fact, I can't figure out how to make that particular popup appear in master. Could you remind me how to get to it?

Jane Sandberg (sandbej) wrote :

Haha never mind; I didn't have the "Charge item price when marked damaged" library setting set to true. I'm adding the pull request tag so that others can help to test this.

tags: added: pullrequest
Michele Morgan (mmorgan) on 2019-03-07
Changed in evergreen:
milestone: none → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
milestone: 3.3.3 → 3.4-beta1
Jason Stephenson (jstephenson) wrote :

Add my signoff here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1742523_making_mark_damaged_strings_translatable-signoff

I'm not sure if we're back porting translation changes, so I just signed off and pushed to working. The signoff branch is rebased on master as of about 12:45 pm EDT 2019-08-01.

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
assignee: Jason Stephenson (jstephenson) → nobody
Galen Charlton (gmc) wrote :

I believe we are backporting translation changes, so I've pushed this to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Jane and Jason!

Changed in evergreen:
importance: Undecided → Low
status: Confirmed → Fix Committed
Galen Charlton (gmc) on 2019-09-11
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers