Comment 2 for bug 1741997

Galen,

All the code looks sane (with one caveat below), but I have a question. Should we take a NULLable depth parameter into account in the bib-is-visible testing function? That might be necessary anyway, if the user were to select "at all libraries" from the result page, and may make it more broadly useful for other purposes where we know a depth selection is possible.

The caveat: I believe you'll want to OR ("|") the default patron filter with any supplied filter that ends up being supplied in the b_attrs context. I ran into exactly that problem over on bug 1736419 which was limiting Located URI records. Testing would tell...