web client: MARC edit indicator box resizes after deleting value

[Kathy Lussier]

Evergreen version: master

If you erroneously add a value to an indicator box in the MARC editor and then delete it, the small indicator box resizes to a long box. A screencast showing this behavior is available at https://drive.google.com/file/d/1lPJDWvjlvxd6ivMMcsfC6junk_9VvSVR/view

[Andrea Neiman (aneiman)]

Confirmed, just saw this yesterday on 3.0.0

[Eva Cerninakova (ece)]

Our librarians confirmed this behavior testing Evergreen 3.3.0

[Janet Schrader (jschrader)]

I can confirm this happens on version 3.2.5 and 3.2.8.

However, even though the box expands, the cursor focus in in the exact middle and you can only enter a single character. Once you do that the box reverts to the correct size.

Janet

[Christine Morgan (cmorgan-z)]

I have a branch that addresses this issue and bug 1830443. Usability is also improved. Colors were tested using the Chrome extension Colorblindly, a colorblindness simulator. Attaching a screenshot of the style changes. Marking bug 1830443 as a duplicate since this branch fixes both.

Branch available here:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cmorgan/LP1735568_LP1830443_MARC_Editor_Fixes

[Elaine Hardy (ehardy)]

Tested on https://bugsquash.mobiusconsortium.org/eg/staff/

Indicator label was editable without the box resizing. Adding new field also able to edit without resizing text box.
Text box size for indicator value is much better.

Colors and layout are much better than current 3.4.1 and earlier.

Not addressed by either bug -- still must sometimes highlight the box for the indicator when adding a new field

[Elaine Hardy (ehardy)]

I have tested this code and consent to signing off with my name, Elaine Hardy, and email, <email address hidden>

[Jane Sandberg (sandbergja)]

Thank you for this fix, Christine. It works well for me in Chrome. However, in Firefox, I can only see the first digit of the MARC tags (see attached screenshot).

[Christine Morgan (cmorgan-z)]

Thanks for looking at this Jane! I tested the display in FireFox on our 3.4.3 test system and don't see the issue you are seeing. I asked another person to look at this and they did not see that issue either. She has a smaller screen than I do and we both changed font size and resolution, still with no issue. FireFox browser version 78.0.2.

[Galen Charlton (gmc)]

I'm also not seeing an issue with the display of the tag on Chrome or on Firefox on Windows or MacOS at various viewport sizes, so for the moment I'll chalk that up as a one-off glitch. I've gone ahead and pushed this to master, rel_3_5, and rel_3_4. Thanks, Christine and Elaine!

[Galen Charlton (gmc)]

See also bug 1889459 about replicating the background color scheme to the Angular MARC editor.