Patron Display of Holds missing "No Copy" for Current Copy entries

[Robert J Jackson]

web staff client 3.0

When bringing up the Holds display list for a patron account in the web staff client only the holds that have "Ready for pickup" or "Waiting for Capture" as a Status show in the list. Holds that would/do show as "Waiting for Copy" in the legacy staff client are not displayed. In the case discovered the count shows Holds (2/11) at top which is correct tally but only the two ready for pickup and the one waiting for capture show in the list of holds.

[Jason Boyer (jboyer)]

It looks like the function that fleshes the volume information; it always assumes that there is a volume available and calls the prefix and suffix functions against a potentially empty value. Branch incoming with fix.

[Jason Boyer (jboyer)]

And here it is:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1732271_holds_acn_affix

To test:
Using a 3.0.1-2ish system, add a hold that doesn't immediately target a copy. Pull up the user and look at their holds. It should say 0/1 holds available but no holds are displayed at all.

Apply patch, repeat test, 1 hold will display with no copy currently targeted.

[Jason Boyer (jboyer)]

Marking this bug as wontfix since this issue was noticed in the work for bug 1646210 and the same fix has already been committed.