web client: Call number affixes missing from several grids

[Kathy Lussier]

A copy's call number prefix / suffix, as well as its part, should display in any grid that displays a call number. For libraries these elements, the affixes and part are really part of the call number and helps staff find / identify the copy listed in the grid.

The call number affixes in particular appear to be missing from all web client grids with the exception of the holdings maintenance grid. I also see that the part is missing from the item status screen (there may be other screens I have missed), but I think that can also be addressed in bug 1528924. These fields need to be included in all other grids that display the call number. In particular, this information is critical for the holds pull list.

[Kathy Lussier (klussier)]

Also, the call number prefix/suffix and the copy's part should also be accessible to print templates whenever the template is able to print a call number.

[Erica Rohlfs (erohlfs)]

I confirmed this bug, because there are interfaces in the XUL client that display the call number prefixes and parts that don't currently display in the web client, notably the copy bucket interface. Other interfaces have already been noted where both XUL and web client do not currently display prefix, suffix, and part, such as the detailed (alternate) view of the Item Status.

[Kyle Huckins (khuckins)]

I've pushed a WIP branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1646210-call-number-affixes

So far it's affecting the following grids:
- Copy Buckets
- Checkin/Capture Holds
- Patron Holds
- Holds Shelf

Grids that I've confirmed already have (working) columns for the affixes:
- Find Copy by Barcode
- Item Status
- Holds Pull List

I'll be checking for further grids that don't yet have the Affix columns. Additionally, right now I'm fleshing out the Affixes through the Holds and Circ services - with the holds, I'd initially attempted doing so through the API, but nothing seemed to work, so instead I opted to flesh them out in the js.

[Kyle Huckins (khuckins)]

After further research I've confirmed that the following grids will need editing to display CN Affixes(Including completed ones as of the initial push):
    [Complete]Copy Buckets
    [Complete]Patron Holds
    [Complete]Checkin/Capture Holds
    [Complete]Holds Shelf
    Renew Items
    In-House Uses
    Patron Checkout
    Transit List
    Bib Record View Holds
    Patron Items Out
    Patron Bills History
    VolCopy Editor?(Displays ID of Call Number)

[Kyle Huckins (khuckins)]

I've made a few commits(and have since squashed them down into one) and rebased to the latest master. The branch now covers the following grids:

Pending Copy Buckets
Copy Buckets
Checkin/Capture Holds
Holds Shelf
Patron Bills History
Patron Checkout
Patron Holds
Patron Items Out
Copy Editor
In-House Uses
Renew Items
Bib Record View Holds
Transit List

[Kathy Lussier (klussier)]

Thank you Kyle! This looks great except in one instance.

Using the Concerto dataset, I put CONC41000567 into transit. When I retrieved the item on the transit list, the prefix did not display as expected. I had no trouble displaying the suffix in this interface.

Both the prefix and suffix displayed as expected in all other interfaces.

Kathy

[Kyle Huckins (khuckins)]

Looks like I made a typo. A terrible, terrible typo. Turns out target_copy.target_copy is not the target_copy I'm looking for. I've fixed the extra target_copy in the transits list and amended my previous commit - should work like a charm now.

[Kathy Lussier (klussier)]

Looks good to me. I signed off on the code and merged it to master and release 3.0. There was a merge conflict in 2.12, so I opted not to backport that far.

Thanks Kyle!

[Kyle Huckins (khuckins)]

Alex Cautley caught an edge case I managed to miss on this - a hold that is waiting for Copy will break the grid, as it doesn't have a volume.

I've pushed the bugfix up to a separate branch atop the latest master, here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1646210-CN-prefix-bugfix

[Kathy Lussier (klussier)]

Nice catch Alex! I verified the problem and verified that Kyle's patch fixed it. I've merged it to master and release 3.0.