i wonder if a code merge could've removed the relevant setTimeout javascript call from your installation.
i got a merge conflict in Open-ILS/web/js/ui/default/staff/cat/catalog/app.js when getting this branch caught up with master. among other changes, the code switched from bracket notation for accessing the 'finally' property:
)['finally'](egProgressDialog.close)
to dot notation:
).finally(egProgressDialog.close)
the important bit here is that the egProgressDialog.close should* be wrapped in a setTimeout, which could've been misplaced if there was a merge conflict with the branch:
).finally(function(){ setTimeout(egProgressDialog.close); });
i merged master's latest changes into this branch and updated it. hopefully it won't have any more conflicts.
* i say "should", but this is arguable. using setTimeout to manipulate the javascript event queue as a means of working around race conditions in angular promises isn't exactly "elegant". i just couldn't figure out a better solution.
Jane,
i wasn't able to replicate the error. :-(
i wonder if a code merge could've removed the relevant setTimeout javascript call from your installation.
i got a merge conflict in Open-ILS/ web/js/ ui/default/ staff/cat/ catalog/ app.js when getting this branch caught up with master. among other changes, the code switched from bracket notation for accessing the 'finally' property: finally' ](egProgressDia log.close) egProgressDialo g.close)
)['
to dot notation:
).finally(
the important bit here is that the egProgressDialo g.close should* be wrapped in a setTimeout, which could've been misplaced if there was a merge conflict with the branch: function( ){ setTimeout( egProgressDialo g.close) ; });
).finally(
i merged master's latest changes into this branch and updated it. hopefully it won't have any more conflicts.
* i say "should", but this is arguable. using setTimeout to manipulate the javascript event queue as a means of working around race conditions in angular promises isn't exactly "elegant". i just couldn't figure out a better solution.