Comment 1 for bug 1723531

Revision history for this message
Jane Sandberg (sandbergja) wrote :

For what it's worth, it seems pretty simple to change the Non-Cataloged Types Editor into an Angular Basic Admin Page, which Bill Erickson made super-easy in the new Angular client. These Basic Admin Pages include pagination *and* sorting, which seems like it would help out with long lists like PINES'.

Here's a quick branch doing just that: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1723531_port_non_cat_types_to_angular

One thing that comes to mind, though, is that the current Non-Cataloged Types Editor has a helpful interface for entering the circulation duration field, while the Angular editor just gives users a regular textbox in which they can type things like "2 hours" or "3 weeks". (see https://github.com/evergreen-library-system/Evergreen/blob/35cf13c59d7b1a851e46b537a4f0356a9e4bc3fc/Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.html#L41)

It would probably be helpful if the Angular FMEditor had a better UI for users to enter interval values in a correct way.

I also suspect that the circulation duration and name fields should be made required (which we could do in fm_IDL.xml).

Thoughts?