Comment 4 for bug 1716475

Revision history for this message
Ben Shum (bshum) wrote :

Tina, I think you've stumbled on a potential odd interaction with the PO template file tpac.

I was mentioning to Galen earlier today that I saw that we're adding an empty string translation as part of this file:

Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2, around line 22 in master

[% l('') %]

That's coming into the PO template for master as msgid "" msgstr "" needing translation. But at the top of the tpac.pot file, there's also a msgid "" with mgstr "" containing the metadata for translation info and generating the PO template.

Looks like you're getting that translation metadata pulled in as the first entry, instead of the empty "" string as expected.

I believe Cesar and Galen intended that the first entry in the sms carrier list show up as blank, so maybe we should alter the line in sms_carrier_selector.tt2 to be translating for ' ' (one space) so that it's different than the default metadata tag and does not cause duplication errors. Or we should put a proper value in that first field somehow? Or remove the translation from it entirely, and leave it empty space, but not translatable.