Comment 7 for bug 1712861

Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Kyle. +1 to wide_holds migration. Did some testing and code review and have a few comments.

1. The Recently Canceled holds tab needs to honor the 'circ.holds.canceled.display_count' and 'circ.holds.canceled.display_age' org unit settings.

In the current code, this is addressed on the API side (see open-ils.circ.holds.retrieve and related APIs).

2. It looks like the default sort order is changing in the new code. Some special sort handling exists in open-ils.circ.holds.retrieve, etc. It looks like the wide_holds API will support these sort additions with some syntax modification (e.g. sorting on "clear_me").