I have not yet signed off on the code because I'm still encountering problems with the Show Clearable Holds button. I was testing the code on a server with 972 holds on the holds shelf. 872 of the holds are past their shelf-expire dates. A handful of those are also canceled. 100 holds are still not considered clearable.
1. When I click the Clearable holds button, the interface only retrieves the holds that are canceled. The shelf-expired holds should also be displaying.
2. When I click the Clear These Holds button, it proceeds to clear all the clearable holds, even the ones that do not display. However, the interface stops the progress at 771 holds. I don't know if this is a pre-existing issue. Because there is no visible finish to clearing the holds, the buttons to return to all holds is disabled.
3. As far as I can tell, all 872 holds were cleared, even though the visible progress indicator stopped at 771.
I have a new branch available at http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ kmlussier/ lp-1712854- hold_ui_ speed_improveme nts that resolves a conflict in hatch.js, rebases the code against master, and adds the new persist settings to server storage.
I have not yet signed off on the code because I'm still encountering problems with the Show Clearable Holds button. I was testing the code on a server with 972 holds on the holds shelf. 872 of the holds are past their shelf-expire dates. A handful of those are also canceled. 100 holds are still not considered clearable.
1. When I click the Clearable holds button, the interface only retrieves the holds that are canceled. The shelf-expired holds should also be displaying.
2. When I click the Clear These Holds button, it proceeds to clear all the clearable holds, even the ones that do not display. However, the interface stops the progress at 771 holds. I don't know if this is a pre-existing issue. Because there is no visible finish to clearing the holds, the buttons to return to all holds is disabled.
3. As far as I can tell, all 872 holds were cleared, even though the visible progress indicator stopped at 771.
I have a screencast showing these steps at https:/ /drive. google. com/file/ d/1V-C6Wu3ueszb uPFDPI9ne1lEEDN S18Ff/view