Web Client: Copy Location Order select box doesn't work as expected

[Terran McCanna]

In 2.12.4 web client:

In the Copy Location Order interface, changing the Context Org Unit selection box does not refresh the list of copy locations displayed on the screen.

You can click the "Apply Changes" button after making your selection in order to update the displayed list, but that is unclear.

Example: If BR1's list is displayed and you select BR2, BR1's list still shows. If you select "Apply Changes" at that point, it seems like BR1's displayed list would be applied to BR2, but that's not what happens - instead, it doesn't apply any changes and just refreshes with BR2's list on screen.

Expected behaviors:
a) If BR1's list is displayed and you make changes, click "Apply Changes" to save the changes.
b) If BR1's list is displayed (and you have not made any changes) when you select BR2 from the dropdownlist, it will refresh the screen with BR2's list.
c) If BR1's list is displayed and you HAVE made changes when you select BR2 from the dropdown list, it will prompt you to save the changes (or not) before refreshing the screen with BR2's list.

[Cesar V (cesardv)]

I agree the "Apply Changes" button's function is ambiguous here. It is not 100% clear at first whether it's supposed to "apply changes" to a change in the selected Org Unit or the change(s) in the ordering of the Copy Locations.

I'd welcome any input on this, but IMO one possible way to correct this ambiguity is to perhaps just change the displayed text of the "Apply Changes" to reflect something more specific, i.e "Change/Refresh Org Unit" or something to that effect.

The other possible way to address it is to change the way the Org Unit dropdown works, so that it automatically updates on-change, doing away with the need for an apply button there.

I'm not sure how feasible this might be in this Dojo interface, alternatively, another option I suppose is to update this interface to angular, but that would be the most involved approach.

[Cesar V (cesardv)]

Actually, it looks to me like the "Apply Changes" button has sort of double function:
  1. updating view to the currently selected Org Unit's list of copy locations
  2. "saving" any changes to the ordering of the copy locations.

However, while function no. 1 works, no. 2 doesn't. I couldn't seem to get an order change to save, no matter what I did after dragging and changing the order, say 9. "Fiction BR3" to the very top of the list, for BR3.

[Cesar V (cesardv)]

Ok, after further testing and poking around the code and database...

It seems that this UI is working correctly, but one must click apply both to switch Org unit contexts (BR1 to BR2), and to apply any order changes.

[Andrea Neiman (aneiman)]

So I'm confirming this, but also removing the webstaffclient tag since this exact behavior is also present in XUL & this is a ported interface.

I agree with Terran's notes about expected behavior. In the current behavior the "Apply Changes" button's double function is counter-intuitive.

[Andrea Neiman (aneiman)]

Allow me to clarify my comment (thank you Friday brain):

I see what Cesar sees here, in that if I select an OU and click "apply changes" and then make changes and then click "apply changes" again, my changes appear to be saved.

[Terran McCanna (tmccanna)]

See current work to angularize the interface at: https://bugs.launchpad.net/evergreen/+bug/1846552

[Terran McCanna (tmccanna)]

Noting that the Angular interface refreshes the list when a new org unit is selected, so part of this problem is resolved. However, the Apply Changes functionality still does not actually save the changes.

(Also, I would prefer that button to be labeled "Save Changes" or something along those lines for clarity.)

[Andrea Neiman (aneiman)]

The branch in comment #18 on bug 1846552 appears to resolve the issues here, so I'm marking this as duplicate.