Webstaff UI issue: When editing a z39.50 overlay record, the "Modify" button is easy to miss

[Jane Sandberg]

I have been exploring the z39.50 overlay features in EG 2.12 and on Webby. While doing so, I have been experimenting with editing z39.50 records as part of that overlay process. The first several times I did so, I would:

1) Click the "Edit Z39.50 Record" button
2) Make some changes to the MARC record
3) Click the "Use Edits" button at the bottom.
4) Continue the overlay process. When the dust settled, I'd notice that I'd lost my edits each time.

It turns out that I was missing the "Modify" button, which I should have clicked between steps 2 and 3. It would be nice if we could safeguard against other users making the same mistake I did:

* Using different language for these buttons.
* Adding the "disabled" class to the "Use Edits" button until the user has actually saved some changes.
* Showing a small modal asking the user if they're sure they don't want to save their changes.
* Changing the workflow slightly
* etc.

Thanks for your consideration! Overall, I am really enjoying the Z39.50 interface in the webstaff client.

[Andrea Neiman (aneiman)]

Confirmed 3.0 beta

Related bug 1702557 -- same issue in acq editor.

Copying over Kathy's comment from that one:

Pointing to this commit in the serials working branch to show an example of where we made this change in another modal:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=d3d5480d474c0826f2a2e13483fe983eb5f93b5f

[Cesar V (cesardv)]

I've a fix for this here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1710405_z3950_overlay_edit_save

Basically, did something similar to what was done in the Acq editor.
There's now just one "Save" button, that will save the marc changes and close the modal to continue the workflow. There's no longer a "Use Edits" button whose only purpose was to close the modal.

[Jane Sandberg (sandbergja)]

Thanks so much, Cesar!

[Jason Etheridge (phasefx)]

Looks good to me, pushed to master. Thanks Cesar!

One cosmetic bug I noticed, with or without this patch. I think it'd be nice if the flat text MARC in the comparison modal would update after saving changes but before overlaying. Playing with the merge profile selector does tickle the changes into view.