acq: need to click two buttons to save edits

Bug #1702557 reported by Andrea Neiman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.0
Fix Released
Undecided
Unassigned

Bug Description

EG 2.12, Web Staff Client

In Selection Lists >> Edit MARC Order Record, you have to click both "Modify" (at the top of the modal) and then "Use Edits" at the bottom of the modal to successfully save edits made to the MARC record.

Ideally it would just be a single button, and I recommend having it be at the top of the modal & named "Save" as this follows what is in the Bib Record MARC Editor.

Revision history for this message
Kathy Lussier (klussier) wrote :

Pointing to this commit in the serials working branch to show an example of where we made this change in another modal:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=d3d5480d474c0826f2a2e13483fe983eb5f93b5f

Revision history for this message
Andrea Neiman (aneiman) wrote :

Related bug 1710405 -- same issue in the z39.50 editor

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Andrea Neiman (aneiman) wrote :

also, confirmed in 3.0 beta

Changed in evergreen:
importance: Undecided → Medium
milestone: none → 3.0-beta2
Changed in evergreen:
milestone: 3.0-beta2 → 3.0-rc
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.0-rc → 3.0.1
Changed in evergreen:
milestone: 3.0.1 → 3.0.2
Changed in evergreen:
milestone: 3.0.2 → 3.0.3
Changed in evergreen:
milestone: 3.0.3 → 3.0.4
Revision history for this message
Cesar V (cesardv) wrote :
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
tags: added: pullrequest
Cesar V (cesardv)
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
Changed in evergreen:
milestone: 3.0.4 → 3.0.5
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

This looks good to me and is a big improvement over clicking two buttons.

While testing the code, I noticed a more serious bug in that the fields originally entered via the acq brief record form did not carry over to the MARC editor after clicking the "Edit MARC Order Record" button. This appears to be a pre-existing bug as I also saw it on a system running vanilla master, so I'll file a new bug, if it hasn't already been filed.

Thanks Cesar!

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
milestone: 3.0.6 → 3.1-rc
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.