Evergreen

Bug #1705524
Comment #10

Comment 10 for bug 1705524

Revision history for this message

Bill Erickson (berick) wrote on 2017-08-03:

#10

Light functionality testing all looks good, minus issues noted below. Seeing the due time for hourly checkouts is pretty great! I also ran the optional post-upgrade SQL one time through on a modified TZ (BM1=America/Los_Angeles) and it behaved as expected for hourly circs.

New branch pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1705524-lib-tz-review

1. Adds sign-off for Mike's last commit overriding the date filter.

2. Fixes a bug in the closed dates editor where it failed adding dates for branches with no org time zone setting. (null ref)

3. Adds a commit to load the timezone setting of the workstation org unit during startup. This is an optimization based on the assumption that the timezone of the workstation org will likely be loaded frequently, in which case this saves us an API call by bundling the lookup with an existing batch org setting call.

4. Adds a commit to s/undef/null in some JS code. (probably squash this).

Issues I did not address in my branch:

1. The release notes are a lot to digest for the casual administrator / end user. I'd love to see a short bullet summary at the top listing the user-facing changes. A note on how to find a list of valid timezone values for the new setting would also be appreciated.

2. The SQL \q echos are gobbling single quotes (and warning about unterminated strings) leading to a bogus optional query. My preference would be to move the optional SQL to the release notes for safe keeping.

3. I get the following console error when (accidentally) checking out an item (owned by BR1, no timezone setting) that's already checked out:

https://docs.angularjs.org/error/$parse/ueoe?p0=circDate%20%7C%20date:

4. I get this console error checkout out a precat item:

Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments:
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: now, _f: undefined, _strict: undefined, _locale: [object Object]
Error
    at Function.createFromInputFallback (https://eg-dev-local/js/ui/default/staff/build/js/moment-with-locales.min.js:1:3248)
    at gb (https://eg-dev-local/js/ui/default/staff/build/js/moment-with-locales.min.js:1:19736)
...
    at https://eg-dev-local/js/ui/default/staff/services/ui.js:129:17
...

The last 2 did not create user-facing problems as far as I could tell.

Removing 'signed-off' tag pending feedback.

Thanks Mike!

Light functionality testing all looks good, minus issues noted below.  Seeing the due time for hourly checkouts is pretty great!  I also ran the optional post-upgrade SQL one time through on a modified TZ (BM1=America/Los_Angeles) and it behaved as expected for hourly circs.

New branch pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1705524-lib-tz-review

1. Adds sign-off for Mike's last commit overriding the date filter.

2. Fixes a bug in the closed dates editor where it failed adding dates for branches with no org time zone setting.  (null ref)

3. Adds a commit to load the timezone setting of the workstation org unit during startup.  This is an optimization based on the assumption that the timezone of the workstation org will likely be loaded frequently, in which case this saves us an API call by bundling the lookup with an existing batch org setting call.

4. Adds a commit to s/undef/null in some JS code.  (probably squash this).

Issues I did not address in my branch:

1. The release notes are a lot to digest for the casual administrator / end user.  I'd love to see a short bullet summary at the top listing the user-facing changes.  A note on how to find a list of valid timezone values for the new setting would also be appreciated.

2. The SQL \q echos are gobbling single quotes (and warning about unterminated strings) leading to a bogus optional query.  My preference would be to move the optional SQL to the release notes for safe keeping.

3. I get the following console error when (accidentally) checking out an item (owned by BR1, no timezone setting) that's already checked out:

https://docs.angularjs.org/error/$parse/ueoe?p0=circDate%20%7C%20date:

4. I get this console error checkout out a precat item:

Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
Arguments: 
[0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: now, _f: undefined, _strict: undefined, _locale: [object Object]
Error
    at Function.createFromInputFallback (https://eg-dev-local/js/ui/default/staff/build/js/moment-with-locales.min.js:1:3248)
    at gb (https://eg-dev-local/js/ui/default/staff/build/js/moment-with-locales.min.js:1:19736)
...
    at https://eg-dev-local/js/ui/default/staff/services/ui.js:129:17
...

The last 2 did not create user-facing problems as far as I could tell.

Removing 'signed-off' tag pending feedback.

Thanks Mike!