Marc_export should include call number prefix and suffix

Bug #1705478 reported by Martha Driscoll on 2017-07-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

When the marc_export program is invoked with the --items option to include holdings information in the 852, the call number is included in $j. If a call number prefix or suffix is present, they should also be output in the 852 in subfields $k (prefix) and $m (suffix).

Martha Driscoll (mjdriscoll) wrote :

Here is a branch that adds the call number prefix and suffix. It will only include the $k or $m if there is one.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/driscoll/lp1705478_marc_export_include_prefix_suffix

tags: added: pullrequest
Dan Pearl (dpearl) on 2017-07-21
Changed in evergreen:
assignee: nobody → Dan Pearl (dpearl)
Dan Pearl (dpearl) wrote :

I tested this by
1) Generating output from Concerto (--all, --items)
2) Applied the patch
3) Added three copies to REC 167:
    Barcode TestPref had a REFERENCE prefix
    Barcode TestSuff had a REFERENCE suffix
    Barcode TestBoth had both a prefix and suffix
4) In staff client, brought up the record detail verifying that the prefixes and suffixes were visible
5) Generated output again
6) Did a diff between the old and new files.

Results: Not as expected. The old output file was identical to the new file.
I probably did something wrong, but I can't sign off on this right now.

Changed in evergreen:
assignee: Dan Pearl (dpearl) → nobody
Martha Driscoll (mjdriscoll) wrote :

Thanks for testing Dan. The concerto data set has 10 call numbers with prefixes and 10 call numbers with suffixes so you should get some subfield $k and subfield $m even without adding your own.

If anyone wants to grep for them in their output, here are the prefixes:
REF BR1
DVD BR2
STORAGE BR4

Here are the suffixes:
REFERENCE
MEDIA
DEPOSITORY

Dan Pearl (dpearl) wrote :

I'll take another look at it, Martha.

Changed in evergreen:
assignee: nobody → Dan Pearl (dpearl)
Dan Pearl (dpearl) wrote :
tags: added: signedoff
Changed in evergreen:
assignee: Dan Pearl (dpearl) → nobody
Galen Charlton (gmc) on 2017-08-02
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
milestone: none → 3.0-alpha
importance: Undecided → Wishlist
status: New → Confirmed
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.0. Thanks, Martha and Dan!

I've added two follow-ups, one to make the $k appear in the field before the $j, and the other to add release notes. Those release notes also cover the enhancement from bug 1692106.

Changed in evergreen:
status: Confirmed → Won't Fix
status: Won't Fix → Fix Committed
Galen Charlton (gmc) on 2017-08-07
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers