web client: update description of receipt template include library settings

[Kathy Lussier]

The following settings:

circ.staff_client.receipt.alert_text
circ.staff_client.receipt.event_text
circ.staff_client.receipt.footer_text
circ.staff_client.receipt.header_text
circ.staff_client.receipt.notice_text

contain a description like the one below:

"Text/HTML/Macros to be inserted into receipt templates in place of %INCLUDE(header_text)%"

With the addition of bug 1680110, these settings can now be called in the web client, but the syntax is a bit different. The description should be updated to reflect the new method for including this text:

{{includes.alert_text}}
{{includes.event_text}}
{{includes.footer_text}}
{{includes.header_text}}
{{includes.notice_text}}

Also, receipt templates are now called Print Templates in the web client, and the description should be updated accordingly.

The change should be fairly easy to make, but the question is when we should make the change. Should it only be added to 3.0, when the xul client will be deprecated? Or should it be changed when the xul client is totally removed?

[Terran McCanna (tmccanna)]

I changed the Importance from Wishlist to Low since presenting incorrect information is a bug that will need to be fixed. I think it should be changed beginning with 3.0.

[Mike Risher (mrisher)]

I've pushed a branch here:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1705302-update-template-description

[Terran McCanna (tmccanna)]

The New Devs Working Group tested this patch and it does work well, except HTML and Macros no longer work in the web client, so it should just be read 'Text to be inserted into Print Templates in place of ...'

(That issue has been reported at: https://bugs.launchpad.net/evergreen/+bug/1801143 )

[Mike Risher (mrisher)]

I pushed a branch with the text adjustment. I have not been able to visually confirm my changes are showing up. I'm having difficulties figuring out where the text in question is in the UI. I searched all through the Work station admin section and within "Print Templates" with no luck so far.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1705302-description-text-update

[Mike Risher (mrisher)]

Update: Found out how where this text lives and was able to confirm the changes are there. We're good to go!

[Jessica Woolford (jwoolford)]

It looks to me like the description is still referring to the way receipts used to work in XUL. I think it's meant to read this way (for example):

Text to be inserted into Print Templates in place of {{includes.alert_text}}

[Terran McCanna (tmccanna)]

I can confirm what Jessica reported. The branch in comment 2 fixed the format so it references the curly braces now, but the branch in comment 4 lost that fix and fixed the HTML/Macro part.

Mike, can you please combine the two fixes into a single branch?

[Mike Risher (mrisher)]

Terran, I just did this. Changes in branches 2 & 4 are both here now:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1705302-update-template-description

Thanks for pointing this out!

[Terran McCanna (tmccanna)]

Thanks, Mike - looks good! My sign off at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1705302-update-template-description-signoff

[Jane Sandberg (sandbergja)]

Committed to master, rel_3_5, and rel_3_4. Thanks, Mike and Terran!