Receipt templates missing Org Unit Includes in Web Client

Bug #1680110 reported by Lynn Floyd
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.12
Fix Released
Undecided
Unassigned

Bug Description

The Org Unit Includes Alert_text, Notice_text, Event_text, Header_text, Footer_text are not implemented in the Receipts for the web client.

They are implemented in the XUL Client by the following macros
* %INCLUDE(notice_text)%
* %INCLUDE(alert_text)%
* %INCLUDE(event_text)%
* %INCLUDE(footer_text)%
* %INCLUDE(header_text)%

Revision history for this message
Lynn Floyd (lfloyd) wrote :
tags: added: webstaffclient
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Here's a branch that adds support to the printing code (egPrint), teaching it how to fetch the settings on demand add them to the print environment, so they can be used by print templates.

The values can be accessed in HTML templates like so:

{{includes.alert_text}}
{{includes.event_text}}
{{includes.footer_text}}
{{includes.header_text}}
{{includes.notice_text}}

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1680110-webstaff-print-includes

Next step will (presumably) be to add these values to all of the default templates so they just work without any manual tweaking required.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Lynn Floyd (lfloyd)
Changed in evergreen:
assignee: nobody → Lynn Floyd (lfloyd)
Revision history for this message
Lynn Floyd (lfloyd) wrote :

I have tested this code and consent to signing off on it with my email address, <email address hidden>, and name, Alynn26(Lynn Floyd)

Changed in evergreen:
status: New → Fix Committed
status: Fix Committed → Confirmed
assignee: Lynn Floyd (lfloyd) → nobody
tags: added: signedoff
Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

This looks good to me. Before merging, I would like to add a commit that adds these options to the commented-out 'help' text at the beginning of the default templates so that users know how to use them. A follow-up commit is forthcoming.

Revision history for this message
Kathy Lussier (klussier) wrote :

Actually, I changed my mind on my last comment. Those comments demonstrate how to include data specific to that template. I would like to find a way to provide assistance for data that can be used on all templates, similar (but better than) to the macros button we had in the xul client, but that can be the topic of another bug.

I've merged these changes to master and release 2.12. Thank you Bill and Lynn!

I plan to file another bug related to the description text used in the receipt include library settings. The current description includes the previous Macro format.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Kathy Lussier (klussier) → nobody
milestone: none → 3.0-alpha
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.