RTL stylesheets should be merged with LTR stylesheets
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Wishlist
|
Unassigned | ||
2.12 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
In LP #1661661, the right-to-left stylesheet Open-ILS/
This approach isn't optimal, as browsers will have to interpret the rules from the first stylesheet and then reinterpret the rules that the RTL stylesheet overrides. It also sends more bytes over the network and involves one more network request. And it is likely that we will have more cases where the RTL styles are forgotten about if they are in a separate stylesheet.
Instead, I think we should be able to handle the RTL logic inline in a single stylesheet using TT2 conditional logic.
summary: |
- RTL spreadsheets should be merged with LTR spreadsheets + RTL stylesheets should be merged with LTR stylesheets |
Changed in evergreen: | |
assignee: | nobody → Galen Charlton (gmc) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
WIP at http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dbs/lp1681009_ rtl_style_ merge - not finished yet and hasn't been tested at all, but I believe it's worthwhile to share as it took about an hour to get this far and it would be unfortunate if someone else duplicated that effort.