Comment 25 for bug 1676608

I've started a new collab branch: collab/gmcharlt/lp1676608_copy_alerts_rebase_2018_02-2

This addresses most of the issues; my responses are detailed below. They use Kathy's numbering from comment 24. I expect to address the remaining ones tomorrow.

3. I've fixed the warning tossed by ui.js.

4. I agree that this would be useful, but suggest that this be handled as an additional bug once this one is merged (and thus not block the overall feature for feature freeze).

5. There was a bug where suppressing the checkout of missing items alert didn't work, which I've fixed. Otherwise, suppression during checkout worked for me. As far as the checkin alerts are concerned, when I activated the relevant copy alert types, I did get new-style alerts.

6: The new OU settings and stock copy alert types are now included in the seed data, not just the upgrade scripts.

7. The copy alert type manager now knows (again) to disabled the Next Status select if the event is not 'Checkin'.

8. I've removed the old alert message field from the copy editor. The branch also includes a DB update path to transfer legacy alert messages to new normal checkin and checkout alerts. Note that the changes to the schema update are such that they are best applied to fresh master database.

9. I've tweaked it so that the new copy alerts button now uses the same editor defaults key as the legacy field, so users who set copy editor defaults should see the new button be active if they had made the old field active.