Evergreen

Bug #1673857
Comment #7

Comment 7 for bug 1673857

Revision history for this message

Josh Stompro (u-launchpad-stompro-org) wrote on 2017-07-17:

Signoff branch at - user/stompro/lp1673857-copy-tags-and-bookplates-signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1673857-copy-tags-and-bookplates-signoff

Testing Notes: I didn't find any major issues. I added an extra commit to add the autocomplete="off" to the tag input box when linking/creating tags.

[1] In Server Administration -> Copy Tag Types, test creating and modifying copy tag types.
As a superuser I had no trouble adding/removing/editing copy tag types. When I switched to a user without the correct permission, I wasn't able to add/edit/delete the copy tag types. I did notice that there is no feedback given when the actions failed. The only way to know that it didn't work is because no new entry showed up in the list(when adding types). It would be helpful for there to be an error message. Once I added the correct permissions to the user, then I was able to admin the copy tags.

[2] In Server Administration -> Copy Tags, test creating and modifying copy tags.
Worked fine, other than the lack of feedback when actions failed.

[3] In the volume/copy editor, test use of the 'Copy Tags' button to link or unlink tags from copies.
  I noticed that the sort for the tag types is case sensitive, which could cause issues if the types are entered with different case standards. "Alpha b" comes before "alpha a".
  The tag types don't seem to be scoped, all of them are shown no mater what the tag type owner is set to.
  The tags seemed to be scoped, those outside of my scope didn't show up in the typeahead search. I was only shown tags with tag ownership that matched my search library settings, even if the copy itself was visible. So if I apply a tag that is owned by CONS to a copy at BR1, and then change my search scope to BR1, I won't be shown the tag in the detailed view.

[4] In the volume/copy editor, test use of the 'Copy Tags' button to create and link new tags on the fly.
This seemed to work fine. If I didn't have the correct permissions to add tags then the add tag button just silently fails which might cause some help tickets to be filed.

[5] In the copy buckets interface, test use of the 'Apply Tags' grid action to link tags to copies.
This worked for me. I don't like the lack of feedback though. There is nothing that says - applied tags to x copies, or something like that.

[6] In the catalog, test the copy_tag(type, search) and copy_tag(*, search) filters. Verify that tag visibility (as controlled by the "public" flag on a copy tag) is respected.
This worked as described.

[7] In the catalog, test the display of copy tags in the copy table on the record summary page.
I didn't see any problem with that. Long tag labels can cause problems but there is another bug where that is going to be addressed.

[8] Test the opac.search.enable_bookplate_search library setting and verify that it causes a 'Digital Bookplates' search option to be added.
The 'Digital Bookplates' search option shows up when the library setting is applied and goes away when it is removed. If I set the setting for one branch, it only shows up when searching that branch only.

Testing Notes: I didn't find any major issues.  I added an extra commit to add the autocomplete="off" to the tag input box when linking/creating tags.

[1] In Server Administration -> Copy Tag Types, test creating and modifying copy tag types.
  As a superuser I had no trouble adding/removing/editing copy tag types.  When I switched to a user without the correct permission, I wasn't able to add/edit/delete the copy tag types.  I did notice that there is no feedback given when the actions failed.  The only way to know that it didn't work is because no new entry showed up in the list(when adding types).  It would be helpful for there to be an error message.  Once I added the correct permissions to the user, then I was able to admin the copy tags.

[2] In Server Administration -> Copy Tags, test creating and modifying copy tags.
  Worked fine, other than the lack of feedback when actions failed.

[3] In the volume/copy editor, test use of the 'Copy Tags' button to link or unlink tags from copies.
  I noticed that the sort for the tag types is case sensitive, which could cause issues if the types are entered with different case standards.  "Alpha b" comes before "alpha a".
  The tag types don't seem to be scoped, all of them are shown no mater what the tag type owner is set to.
  The tags seemed to be scoped, those outside of my scope didn't show up in the typeahead search.  I was only shown tags with tag ownership that matched my search library settings, even if the copy itself was visible.  So if I apply a tag that is owned by CONS to a copy at BR1, and then change my search scope to BR1, I won't be shown the tag in the detailed view.

[4] In the volume/copy editor, test use of the 'Copy Tags' button to create and link new tags on the fly.
  This seemed to work fine.  If I didn't have the correct permissions to add tags then the add tag button just silently fails which might cause some help tickets to be filed.

[5] In the copy buckets interface, test use of the 'Apply Tags' grid action to link tags to copies.
  This worked for me.  I don't like the lack of feedback though.  There is nothing that says - applied tags to x copies, or something like that.

[7] In the catalog, test the display of copy tags in the copy table on the record summary page.
  I didn't see any problem with that.  Long tag labels can cause problems but there is another bug where that is going to be addressed.

[8] Test the opac.search.enable_bookplate_search library setting and verify that it causes a 'Digital Bookplates' search option to be added.
  The 'Digital Bookplates' search option shows up when the library setting is applied and goes away when it is removed.  If I set the setting for one branch, it only shows up when searching that branch only.