Web client: Adjust to zero option is missing from web client

Bug #1671596 reported by Kathy Lussier on 2017-03-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Jason Etheridge

Bug Description

The negative balance work was completed after the initial circulation work was added for the web client. As a result, the Adjust to Zero option is not available in the web client.

Kathy Lussier (klussier) wrote :

And while I've got bug 1671603 on my mind, when this action is added, there should also be a prompt that appears asking the user to confirm the account adjustment.

Andrea Neiman (aneiman) wrote :

Confirmed & adding a note that the warning sound should be tied to the prompt, to mimic the behavior in XUL.

Changed in evergreen:
status: New → Confirmed
tji@sitka.bclibraries.ca (tji) wrote :

Just a note related to Adjust to Zero.

On XUL client, Adjust to Zero and Void All Billings on the Action for Selected Transactions are controlled by staff permissions. Those staff who do not have the required permissions do not see them. I hope to keep this feature on the Web Client.

Kathy Lussier (klussier) wrote :

Yes, I agree with Tina on the permissions.

Jason Etheridge (phasefx) wrote :

I pushed collab/phasefx/webstaff-bugs-lp1671596 which adds the action, but does not handle the pre-use UI perm check.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=2ffe1dd14035afc706206f6f05938ba4bacdb665

Changed in evergreen:
milestone: none → 3.0-alpha
assignee: nobody → Jason Etheridge (phasefx)
tags: added: pullrequest
Jason Etheridge (phasefx) wrote :

For the UI perm check, I think we should open a bug for a general UI feature for the web client; make something we can re-use as desired in any interface

Andrea Neiman (aneiman) wrote :

Noting re permissions that the action is correctly controlled by permissions, but the UI doesn't suppress the field from being visible. +1 to Jason's suggestion of a reusable UI permissions check function for use in other areas of the web staff client.

I have tested this code & consent to signing off on it with my name, Andrea Neiman and email address <email address hidden>

tags: added: signedoff
Galen Charlton (gmc) wrote :

Pushed to master. Thanks, Jason and Andrea!

Due to the desire for a permission check to affect the UI, and due to other ongoing work with the adjust to zero feature, I'm electing not to backport this to rel_2_12 at this time.

Changed in evergreen:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers