Web client: Users can void bills without first confirming the action

Bug #1671603 reported by Kathy Lussier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.12
Fix Released
Medium
Unassigned

Bug Description

In the xul client, when voiding a bill, you can get up to three warnings that you must confirm before the bill is voided:

1. The first warning only comes up for libraries that have prohibited negative balances. It warns the user that they may be violating local policy and asks if they want to continue.

2. The next prompt asks the user to confirm that they would like to void all billings on bill # x.

3. The final prompt asks the user to confirm that they would like to void $x.xx worth of line item billings.

There is no request to confirm an action to void billings in the web client. After the user selects the void option, the system immediately voids the bill.

I think 2-3 prompts is probably excessive and can be reduced to just 1 for all libraries, even those that have prohibited balances. Perhaps something that says: "Are you sure you would like to avoid $x.xx worth of line item billings on bill(s) y and z?"

Revision history for this message
Andrea Neiman (aneiman) wrote :

Confirming & adding a note that when this is resolved, I recommend a warning sound with at least the first confirmation in order to mimic behavior in XUL.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Andrea Neiman (aneiman) wrote :

And FWIW I agree with Kathy that only a single prompt is needed.

Revision history for this message
Jason Etheridge (phasefx) wrote :

branch in progress: collab/phasefx/webstaff-lp1671603

Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

force-pushed a new branch. Handles Void Billings from Full Details and Void All Billings from the main UI

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0-alpha
Revision history for this message
Jason Etheridge (phasefx) wrote :
Revision history for this message
Andrea Neiman (aneiman) wrote :

I have tested this code & consent to signing off on it with my name, Andrea Neiman & my email address, <email address hidden>

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.