Wish List - New action trigger for SMS Preminder

[Terran McCanna]

We developed an action trigger to send out SMS texts 3 days prior to an item's due date.

I'm working on getting it into the correct format to submit, and I'll make it disabled by default.

[Terran McCanna (tmccanna)]

I'm not at all sure I created this patch correctly, but here goes:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9c8ea505789526191b644e7e3b26ded6c485c2cb

[Remington Steed (rjs7)]

Terran, I just looked over your branch (I haven't tested it though), and I think it looks mostly right. One small problem I see is that instead of using an explicit upgrade script number, you should just use "XXXX" (both in the filename and in the "SELECT evergreen.upgrade_deps_block_check(..." line). The committer will fill in whatever the next number is when it's committed.

Also, there is a minor problem with your release notes entry. The header underline ("^^^^") needs to be the same length as the header text.

Besides those small issues, I think you have all the right pieces.

[Terran McCanna (tmccanna)]

Thank you, Remington! I'll work on the corrections.

[Terran McCanna (tmccanna)]

Second attempt:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=db74c732c94758b36e4d8aba784fec2effbf2229

[Chris Sharp (chrissharp123)]

Signoff branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1668734_sms_preminder_action_trigger

Though we try as a rule to have people from different organizations do the signoffs on each other's patches, factoring in Remington's feedback and the fact that we have been running this code in PINES production for several months, I think we're good.

[Galen Charlton (gmc)]

Pushed to master, along with a couple tweaks. Thanks, Terran and Chris!