Comment 13 for bug 1661688

This works well in testing. I signed off on the commit, but added another commit to add some tweaks to the code:

1. I added a link to the record of the patron who originally placed a hold. In the email thread I linked to in comment #2, Tina Ji had suggested we add this link. "This will help staff check whether there is any note or alert or similar message in the account allowing the hold to be pickup up other people (to address the privacy issue)" For some reason, her message doesn't show up in the archive, but it's still in my Inbox, and I think it's a good addition to this code. The link will open in a new tab so as not to disrupt the ongoing checkout.

2. I tweaked the language a bit because I thought the phrasing - "This item is currently on the holds shelf for another patron for John Smith" - was a little awkward. It now says "This item is currently on the holds shelf for another patron: John Smith"

3. I removed the setting so that it would return as null, as described by Jason in comment #10.

The new branch is available at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/LP1661688_alt_patron_pickup_signoff_and_additions

I know a lot of people who are going to be very happy with this feature when it's available!